59 task write trails drawing feature functions calculate smoothness#94
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #94 +/- ##
==========================================
+ Coverage 98.51% 98.55% +0.03%
==========================================
Files 18 18
Lines 1009 1035 +26
==========================================
+ Hits 994 1020 +26
Misses 15 15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Asanto32
left a comment
Asanto32
left a comment
There was a problem hiding this comment.
A few things to change, mainly to make sure it works with negtaive x/y changes
Asanto32
left a comment
Asanto32
left a comment
There was a problem hiding this comment.
Overall looks pretty good, makes more sense than first pass. Can we have negative values for x,y or is everything in the first quadrant?
Asanto32
left a comment
Asanto32
left a comment
There was a problem hiding this comment.
Very minor comment about the name "arc_length". And whether this works with points when (x,y) < 0, ie.e outside the first quadrant (or is that impossible due to the Curious export?
Otherwise, letsgomets
I'm pretty sure negative points is impossible from curious export |
cgmaiorano
deleted the
59-task-write-trails-drawing-feature-functions-calculate_smoothness
branch
2 participants
The calculate_smoothness function calculates the path smoothness based on curvature changes. Lower values indicate smoother paths. This function calculates angles between consecutive segments and returns the standard deviation of these angles as a measure of smoothness.
This function is calculated per segment